[Issue #179]: Adds System.Threading.Timer for aggregate change delay.#182
Open
Zettersten wants to merge 1 commit intoJeringTech:masterfrom
Open
[Issue #179]: Adds System.Threading.Timer for aggregate change delay.#182Zettersten wants to merge 1 commit intoJeringTech:masterfrom
Zettersten wants to merge 1 commit intoJeringTech:masterfrom
Conversation
Member
|
My bad, when I was looking through your changes I realized that I'd already written debouncing logic: Javascript.NodeJS/src/NodeJS/Utils/FileWatching/FileWatcherService.cs Lines 137 to 177 in 5999180 We were debouncing, but with a fixed, small debounce time of 1ms. Would you like to amend your PR to add an option for configuring that duration? Changes to OutOfProcessNodeJSService no longer necessary. The option name/comments should indicate that we are debouncing, not aggregating changes over a set time period. Name should be something like "DebounceDuration". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.