Merged
Conversation
Removed references to requirements.txt and run_pytests.py in README and PR template, updating instructions to use Poetry for dependency management and testing. Modified LICENSE update logic in change_project_attributes.py to replace the author from the original 'Jérémie Gince'.
Corrected the spelling of 'Jérémie Gince' to 'Jeremie Gince' in the LICENSE file to ensure consistency and accuracy.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Eliminated the RUN_SLOW_TESTS flag, slow test marker, and pytest command-line option for running slow tests. This simplifies the test configuration by removing unused or unnecessary slow test handling logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several updates across multiple files to improve code accuracy, update dependencies, and enhance documentation. The most important changes include the removal of outdated references, the correction of typos, and the adoption of
poetryfor dependency management.Documentation updates:
.github/pull_request_template.md: Simplified the instructions for running tests by removing the reference torun_pytests.pyand keeping only thepytestcommand.README.md: Updated the dependency installation instructions to usepoetryinstead ofrequirements.txt. Removed references torun_pytests.pyand clarified thatpyproject.tomlhandles dependencies and project configuration. [1] [2] [3]Code corrections:
change_project_attributes.py: Fixed a typo in the variable namepakage_name, correcting it topackage_name.LICENSE: Corrected the spelling of the author's name from "Jérémie Gince" to "Jeremie Gince" for consistency.Dependency management:
requirements.txttopoetryfor managing dependencies, reflecting modern best practices.Checklist
Please complete the following checklist when submitting a PR. The PR will not be reviewed until all items are checked.
Make sure that the tests passed and the coverage is
sufficient by running
python run_pytests.py --tests_folder=testsorpytest tests --cov=src --cov-report=term-missing.You can do this by running
black src tests.You can do this by running
isort src tests.You can do this by running
mypy src tests.