RGH Recoil TOF geometry and reconstruction by niwgit · Pull Request #921 · JeffersonLab/coatjava

niwgit · 2025-10-29T14:55:22Z

This PR includes the geometry and reconstruction for RGH recoil TOF detector.
The reconstruction follows a similar approach as in ATOF.
Running recon-util with engine org.jlab.service.recoiltof.RECOILTOFEngine produces new hipo banks RECOILTOF::hits and RECOILTOF::clusters.

…dius

…tes of bar hits

c-dilks

POM fixes, to be consistent with the current development branch:

reconstruction/recoiltof/pom.xml

Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>

c-dilks · 2025-10-29T20:36:15Z

Great, now it builds and passes most CI tests, except for dependency analysis. We require POMs to specify exactly what dependencies are needed, no more no less. See errors here: https://github.com/JeffersonLab/coatjava/actions/runs/18916433992/job/54001572954?pr=921#step:7:1699

Usually this is straightforward to fix; see other reconstruction modules' POM files for example dependency XML nodes.

niwgit · 2025-10-30T00:28:44Z

Thanks. Should I just add "Used undeclared dependencies" to the pom.xml and remove "Unused declared dependencies"?

c-dilks · 2025-10-30T16:54:18Z

Thanks. Should I just add "Used undeclared dependencies" to the pom.xml and remove "Unused declared dependencies"?

Yes, that's usually enough.

c-dilks · 2025-10-30T18:14:54Z

Sometimes certain dependencies come through transitively too, so you may need to be a bit more precise with specifying what your code really needs. For example, if A depends on B which depends on C, and your code depends on C, you need to specify C as a dependency, not B (even if both cases lead to successful compilation).

niwgit · 2025-10-30T19:00:33Z

What files should I consider when including dependencies? Is that for import statements in reconstruction/recoiltof/src/main/java/org/jlab/service/recoiltof/RECOILTOFEngine.java?

c-dilks · 2025-10-30T20:42:04Z

What files should I consider when including dependencies? Is that for import statements in reconstruction/recoiltof/src/main/java/org/jlab/service/recoiltof/RECOILTOFEngine.java?

The POM file reconstruction/recoiltof/pom.xml applies to all files within reconstruction/recoiltof/, that is, consider all the imports in all the Java files within that directory.

niwgit · 2025-10-30T20:49:29Z

The java files use "import org.jlab.geom" and "import org.jlab.detector". I used "org.jlab.clas:clas-geometry" and "org.jlab.clas:clas-detector" as dependencies in pom.xml. The compiler says those are unused. What should I change those dependencies to?

reconstruction/recoiltof/pom.xml

Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>

raffaelladevita

To avoid conflicts, the suggested changes should be done after #504 is merged and this fork updated

raffaelladevita · 2025-12-19T22:41:22Z

common-tools/clas-detector/src/main/java/org/jlab/detector/base/DetectorType.java

    AHDC      (24, "AHDC"),
    ATOF      (25, "ATOF"),
    RECOIL    (26, "RECOIL"),
+    RECOILTOF (27, "RECOILTOF"),


it may be better to use an acronim such as RTOF and, similarly, RTRK for the RECOIL

raffaelladevita · 2025-12-19T22:50:37Z

...tools/clas-jcsg/src/main/java/org/jlab/detector/geant4/v2/recoil_tof/RecoilTOFConstants.java

I suggest reorganizing these classes under the following directory structure:
.../v2/recoil/tof/RecoilTOFConstants.java
.../v2/recoil/trk/...

Also, if constants are the same in the two detectors, a single class could be used

raffaelladevita · 2025-12-19T22:56:57Z

...s/clas-jcsg/src/main/java/org/jlab/detector/geant4/v2/recoil_tof/RecoilTOFGeant4Factory.java

see the comment above about the directory structure

raffaelladevita · 2025-12-19T22:59:45Z

etc/bankdefs/hipo4/data.json

-  },  
+  },
+  {
+    "name" : "RECOILTOF::tdc",


following the suggested change to DetectorType, this should become RTOF

raffaelladevita · 2025-12-19T23:00:53Z

etc/bankdefs/hipo4/recoiltof.json

@@ -0,0 +1,91 @@
+[
+  {
+    "name": "RECOILTOF::hits",


see the comment above about the name

raffaelladevita · 2025-12-19T23:15:55Z

reconstruction/recoiltof/src/main/java/org/jlab/rec/recoiltof/banks/RecoBankWriter.java

+
+        DataBank hitbank = this.fillRECOILTOFHitBank(event, barHits);
+        if (hitbank != null) {
+            event.appendBank(hitbank);


it is more efficient to append both banks at once

raffaelladevita · 2025-12-19T23:17:42Z

reconstruction/recoiltof/src/main/java/org/jlab/rec/recoiltof/cluster/RECOILTOFCluster.java

I suggest renaming to RTOFCluster

raffaelladevita · 2025-12-19T23:20:41Z

reconstruction/recoiltof/src/main/java/org/jlab/rec/recoiltof/constants/Parameters.java

these constants are already defined in the geometry package and should not be duplicated
units should be cm

raffaelladevita · 2025-12-19T23:25:08Z

reconstruction/recoiltof/src/main/java/org/jlab/rec/recoiltof/hit/BarHit.java

To follow preexisting naming conventions, RECOILTOFHit could become RTOFRawHit and BarHit RTOFHit

raffaelladevita · 2025-12-19T23:28:52Z

reconstruction/recoiltof/src/main/java/org/jlab/service/recoiltof/RECOILTOFEngine.java

+            return true;
+        }
+
+        DataBank bank = event.getBank("RUN::config");


line 41 to 51 are not necessary

niwgit added 7 commits March 19, 2025 11:03

Implementation of recoil TOF geometry for RGH

d6dee06

Added TDC bank for recoil TOF, change horizontal opening angle and ra…

4ae199c

…dius

Initial implementation of reconstruction for RGH recoil TOF

fb3828a

Few changes related to positioning TOF plane and save global coordina…

07835d5

…tes of bar hits

Added sector info to RECOILTOF::clusters bank

7f9c892

Change sign of rotation angle for coordinate transformation

d11a68c

Change long bar length in recoil TOF 20 cm -> 27.5 cm

861539a

niwgit requested review from baltzell, c-dilks, drewkenjo and raffaelladevita as code owners October 29, 2025 14:55

c-dilks reviewed Oct 29, 2025

View reviewed changes

reconstruction/recoiltof/pom.xml Outdated Show resolved Hide resolved

reconstruction/recoiltof/pom.xml Show resolved Hide resolved

reconstruction/recoiltof/pom.xml Show resolved Hide resolved

c-dilks and others added 2 commits October 29, 2025 12:49

Merge branch 'development' into recoil_tof_reco

de0916a

Match the coatjava version and corrected parent in pom.xml

c7d4611

Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>

Fix dependencies in pom.xml

9d0557a

Added few more dependencies

173bbe8

c-dilks reviewed Oct 30, 2025

View reviewed changes

reconstruction/recoiltof/pom.xml Show resolved Hide resolved

Remove unused dependencies

70bc333

Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>

raffaelladevita mentioned this pull request Dec 19, 2025

Recoil detector #504

Open

raffaelladevita requested changes Dec 19, 2025

View reviewed changes

baltzell added the gemc label Dec 20, 2025

Conversation

niwgit commented Oct 29, 2025

Uh oh!

c-dilks left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

c-dilks commented Oct 29, 2025

Uh oh!

niwgit commented Oct 30, 2025

Uh oh!

c-dilks commented Oct 30, 2025

Uh oh!

c-dilks commented Oct 30, 2025

Uh oh!

niwgit commented Oct 30, 2025

Uh oh!

c-dilks commented Oct 30, 2025

Uh oh!

niwgit commented Oct 30, 2025

Uh oh!

Uh oh!

raffaelladevita left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c-dilks left a comment •

edited

Loading