Remove MC-specific condition in DC hit reconstruction#441
Closed
baltzell wants to merge 2 commits intodevelopmentfrom
Closed
Remove MC-specific condition in DC hit reconstruction#441baltzell wants to merge 2 commits intodevelopmentfrom
baltzell wants to merge 2 commits intodevelopmentfrom
Conversation
baltzell
force-pushed
the
dc-tdigi-unc
branch
2 times, most recently
from
47693c5 to
2cfd7a1
Compare
c-dilks
requested review from
N-Plx,
drewkenjo,
gurjyan,
hauenst,
mcontalb,
raffaelladevita,
tongtongcao and
zieglerv
as code owners
Member
That's probably too many reviewers, sorry! One one hand, our new CODEOWNERS file is working as expected (it auto requests PR reviews); on the other hand, we should reduce the number of owners for each module |
zieglerv
approved these changes
Jul 10, 2025
baltzell
force-pushed
the
dc-tdigi-unc
branch
from
874412f to
33158cf
Compare
baltzell
force-pushed
the
dc-tdigi-unc
branch
from
33158cf to
eef5296
Compare
baltzell
force-pushed
the
dc-tdigi-unc
branch
from
eef5296 to
52a8ff8
Compare
Collaborator
Author
|
This should be included in #905 if it's still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separating this from #422 and #434.
This was discussed to come after the switch to real run numbers.