Only use GOOGLE_TV constants for Android <14#368
Open
ius wants to merge 1 commit intoJeffLIrion:masterfrom
Open
Only use GOOGLE_TV constants for Android <14#368ius wants to merge 1 commit intoJeffLIrion:masterfrom
ius wants to merge 1 commit intoJeffLIrion:masterfrom
Conversation
Chromecast HD with Android 14 requires the generic Android 13/14 constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromecast (HD) with Android 14 currently fails to return
current_appcorrectly. See home-assistant/core#153778.The 'Chromecast only' special cased command constants prevent the code path from reaching the (working) Android 13/14 constants. Fixed it by relying on the generic constants for Android 14.
Tested using: