debouncing componentWillRecieveprops causing props and nextprops to r…#135
Open
sanjay1909 wants to merge 1 commit intoJedWatson:masterfrom
Open
debouncing componentWillRecieveprops causing props and nextprops to r…#135sanjay1909 wants to merge 1 commit intoJedWatson:masterfrom
sanjay1909 wants to merge 1 commit intoJedWatson:masterfrom
Conversation
|
@sanjay1909 This library is pretty much abandoned. Have you've glimpsed at the plethora of issues? I wrote react-codemirror2 and have been actively maintaining it because of the frustrations I've encountered here. Not to mention the lack of tests, heavy dependencies, ancient documentation, etc. I am shocked people are still grasping on to this library... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am sure you would have debounced componentWillReceivePRops for some purpose in the past. Look like something along the line got fixed, which is breaking your project now. I have removed the debouncing step and it works. You know the best ... Thanks for this project