Add .npmignore to avoid path conflicts#118
Open
marcofugaro wants to merge 1 commit intoJedWatson:masterfrom
Open
Add .npmignore to avoid path conflicts#118marcofugaro wants to merge 1 commit intoJedWatson:masterfrom
marcofugaro wants to merge 1 commit intoJedWatson:masterfrom
Conversation
sapegin
reviewed
Jul 5, 2017
| @@ -0,0 +1 @@ | |||
| src/ | |||
Contributor
There was a problem hiding this comment.
It’s better to use files field in package.json and explicitly specify files you want to publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried using this package with create-react-app and it breaks the webpack compilation because it has issues with the CaseSensitivePathsPlugin
here is the issue:
this issue does not happen if in the package is not present a
src/Codemirror.jsThis should also solve issue #108