Update README.md and example to add changeObj parameter to onChange property#116
Open
YilinGao wants to merge 2 commits intoJedWatson:masterfrom
Open
Update README.md and example to add changeObj parameter to onChange property#116YilinGao wants to merge 2 commits intoJedWatson:masterfrom
YilinGao wants to merge 2 commits intoJedWatson:masterfrom
Conversation
YilinGao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read
React-CodeMirror's source code and found that theonChangeproperty actually has 2 return values, i.e,newCodeandchangeObj, instead of the only onenewCodein the current document. WithchangeObjprogrammers can do more elaborate work (eg, emitting event of changed values instead of the whole trunk of new code). I regard it worthwhile to document this second parameter to give programmers more choices.