You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi all, I've been working with pdfkit and found several cases where wkhtmltopdf outputs errors, but still generates a pdf. I would like to be able to manually control how the pdf-kit responds to errors.
ps: I apologize if I violate protocol in any way, this is my first time doing pull request to opensource.
Hi, thanks for the work! Not sure about it though, since when using this option any errors will be ignored, even when pdf is not generated. More correct way is to check if we got any output and if there are errors - we can ignore those, and if output is missing - properly raise an exception
Hi, thanks for the work! Not sure about it though, since when using this option any errors will be ignored, even when pdf is not generated. More correct way is to check if we got any output and if there are errors - we can ignore those, and if output is missing - properly raise an exception
Hey,
Thanks for the quick review! I have taken your remarks into account and updated pull request, also I added info about the changes to README.
Thank you, this errors looks vary unusual.
No problem, we all have a job:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, I've been working with pdfkit and found several cases where wkhtmltopdf outputs errors, but still generates a pdf. I would like to be able to manually control how the pdf-kit responds to errors.
ps: I apologize if I violate protocol in any way, this is my first time doing pull request to opensource.