Conversation
PanZezhong1725
requested changes
Nov 12, 2024
xgqdut2016
force-pushed
the
random_sample_workspace
branch
from
bb29825 to
c4bddda
Compare
xgqdut2016
force-pushed
the
random_sample_workspace
branch
from
d453160 to
ad66af0
Compare
xgqdut2016
force-pushed
the
random_sample_workspace
branch
from
85e1629 to
8068970
Compare
PanZezhong1725
approved these changes
Dec 19, 2024
PanZezhong1725
requested changes
Dec 19, 2024
| int voc; | ||
| DT rDtype; | ||
| int rLength; | ||
| int step; |
Collaborator
There was a problem hiding this comment.
指针偏移请使用size_t， 命名使用offset一类。其余使用int的地方都需要修改，根据情况使用uint64或int64
|
|
||
| def random_sample(data, random_val, topp, topk, voc, temperature, torch_device): | ||
| indices = torch.zeros([topk], dtype = torch.int64) | ||
| if(torch_device == "cuda"): |
Collaborator
There was a problem hiding this comment.
可以均使用int64临时替代，不用再判断cuda了
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.