IECoreVDB : Python bindings renamed from pyopenvdb to openvdb in later versions#1455
Open
boberfly wants to merge 1 commit intoImageEngine:RB-10.5from
Open
IECoreVDB : Python bindings renamed from pyopenvdb to openvdb in later versions#1455boberfly wants to merge 1 commit intoImageEngine:RB-10.5from
boberfly wants to merge 1 commit intoImageEngine:RB-10.5from
Conversation
Member
|
Thanks Alex! It looks like OpenVDB 12 also switches the Python bindings from pybind11 to nano bind - do you know how that affects our interoperability bindings in https://github.com/ImageEngine/cortex/blob/main/src/IECoreVDB/bindings/IECoreVDBModule.cpp? |
Contributor
Author
|
Good question, I can tell you it still compiled fine but I'll do some closer testing here or run the unit tests. |
edfa3a1 to
0004638
Compare
Contributor
Author
|
Turns out Cortex just silently didn't build OpenVDB from the logs. I started to make a https://nanobind.readthedocs.io/en/latest/porting.html#type-casters |
…ython bindings renamed from pyopenvdb to openvdb in later versions
0004638 to
ff356e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally describe what this PR will do, and why it is needed.
pyopenvdbfails, try the renamedopenvdbin later versions in a try/except.Related Issues
Dependencies
Breaking Changes
Checklist