IECoreUSD::ShaderAlgo : Round-trip ColorSpace data on shader parameters.#1453
Open
boberfly wants to merge 1 commit intoImageEngine:RB-10.6from
Open
IECoreUSD::ShaderAlgo : Round-trip ColorSpace data on shader parameters.#1453boberfly wants to merge 1 commit intoImageEngine:RB-10.6from
boberfly wants to merge 1 commit intoImageEngine:RB-10.6from
Conversation
9c4b8e5 to
ab4680c
Compare
ab4680c to
5e2d470
Compare
566ceee to
d1f055b
Compare
d1f055b to
8525464
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally describe what this PR will do, and why it is needed.
Related Issues
Dependencies
Breaking Changes
<paramName>_colorspaceparameters existing as real parameters on the USD side, then it'll be problematic but I doubt it would be in-practice. Looking ataiImagethey use a dedicatedcolor_spaceparameter so I doubt it.Checklist
I am using the CI to test this one as I've not got Cortex setup in a proper way yet, thanks! :)