Fix: linspace accepts integer divisions only + undefined variable bug#94
Open
CsatiZoltan wants to merge 2 commits intoImage-Py:masterfrom
Open
Fix: linspace accepts integer divisions only + undefined variable bug#94CsatiZoltan wants to merge 2 commits intoImage-Py:masterfrom
CsatiZoltan wants to merge 2 commits intoImage-Py:masterfrom
Conversation
CsatiZoltan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I checked all the occurences of linspace using
grep -rn "linspace" ./from the main directory of ImagePy. In all the cases when the third argument of linspace was float, I probed the given method in debugging mode and they indeed failed. After these corrections, the linspace issue is solved.
The other change is for an undefined variable.