feat: add support for optional 'errors' field in MobileDocument#27
Merged
peppelinux merged 1 commit intoIdentityPython:mainfrom Jan 30, 2026
Merged
Conversation
- Add optional 'errors' parameter to MobileDocument.__init__() - Include 'errors' field in dump() output when present - Add comprehensive test suite (test_09_errors_field.py) - Fixes TypeError when parsing Device Response with status != 0 - ISO 18013-5 compliance for error handling - All tests pass (36/36) - fix: handle simple values in list elements within _decode_claims When elementValue is a list (e.g., nationality: ['FR']), elements can be simple values (strings, numbers) instead of dicts. Added check to handle both cases instead of assuming all elements have .items() method. See docs/FIX_ERRORS_FIELD.md for detailed documentation
Member
|
excellent not sure to keep FIX_ERROR_FIELDS.md in the future going to resolve the pending PRs and release 1.1.0 today if possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support in order to read Mdoc issued by "France-Identite" Wallet : https://playground.france-identite.gouv.fr/doc/marketplace/wallets/fin/
See docs/FIX_ERRORS_FIELD.md for detailed documentation