fix crash when user ID attribute is missing from reply#484
Open
guillomovitch wants to merge 1 commit intoIdentityPython:masterfrom
Open
fix crash when user ID attribute is missing from reply#484guillomovitch wants to merge 1 commit intoIdentityPython:masterfrom
guillomovitch wants to merge 1 commit intoIdentityPython:masterfrom
Conversation
5a599c2 to
f5cf5ec
Compare
Author
|
Hello. May I have any kind of feedback about this PR, wich seems to be relatively trivial ? |
f5cf5ec to
2cced4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one of the attributes mentionned in user_id_from_attrs is missing from the IdP answer, SATOSA will crash with the following exception (missing attribute is called sub in this specific case):
This PR fixes this issue by ensuring missing attributes are skipped.