Enforce backend and frontend names to be unique#376
Open
kuba00739 wants to merge 2 commits intoIdentityPython:masterfrom
Open
Enforce backend and frontend names to be unique#376kuba00739 wants to merge 2 commits intoIdentityPython:masterfrom
kuba00739 wants to merge 2 commits intoIdentityPython:masterfrom
Conversation
Sanity checks to ensure that none of the frontend and backend names are the same.
Added missing variable
|
|
||
| for backend in backend_modules: | ||
| if backend.name in names: | ||
| raise SATOSAConfigurationError("The name " + backend.name + " is taken!") |
Member
There was a problem hiding this comment.
Suggested change
| raise SATOSAConfigurationError("The name " + backend.name + " is taken!") | |
| raise SATOSAConfigurationError("The backend name " + backend.name + " is already used.") |
|
|
||
| for frontend in frontend_modules: | ||
| if frontend.name in names: | ||
| raise SATOSAConfigurationError("The name " + frontend.name + " is taken!") |
Member
There was a problem hiding this comment.
Suggested change
| raise SATOSAConfigurationError("The name " + frontend.name + " is taken!") | |
| raise SATOSAConfigurationError("The frontend name " + frontend.name + " is already used.") |
Member
|
I think it's good to have this. However, this is doing the right thing but in the wrong way. We should introduce a configuration validation step where this kind of checks should be taking place. Ideally, we can have a configuration schema and check against that directly. I don't mind merging this to help when these issues come up, but we should re-iterate to properly fix this and other configuration checks as a step in the loading process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions: