Skip to content

Conversation

@stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Dec 17, 2025

What this PR does / why we need it: The repository has been inundated with potential sensitive data and article-only deposits that conflict with the policies and mission.
Depositors should receive an additional confirmation request on publishing, that they acknowledge.

Which issue(s) this PR closes: IQSS/dataverse.harvard.edu#359

Special notes for your reviewer: It was decided not to modify the APIs at this time.

Suggestions on how to test this: Use JSF UI to publish a draft dataset with and without the setting "PublishDatasetDisclaimerText" set. You should see the disclaimer, contained in the setting, when the setting is set and the "Continue" button should be disabled until the checkbox is checked.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
image

Is there a release notes update needed for this change?: included

Additional documentation:

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship marked this pull request as draft December 17, 2025 19:38
@stevenwinship stevenwinship added FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) Feature: Publishing & Versions Original size: 3 Size: 10 A percentage of a sprint. 7 hours. labels Dec 17, 2025
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) label Dec 17, 2025
@coveralls
Copy link

coveralls commented Dec 18, 2025

Coverage Status

coverage: 24.333% (-0.001%) from 24.334%
when pulling a2297fb on 359-enhance-publishing-message-acknowledgement
into cc37d4d on develop.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) label Dec 31, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) label Jan 15, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@sekmiller sekmiller self-assigned this Jan 21, 2026
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jan 21, 2026
@github-actions

This comment has been minimized.

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of hate it when an integration test wipes out data or settings, but I know I'm in the minority here.

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jan 21, 2026
@sekmiller sekmiller removed their assignment Jan 21, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 16 FY26 Sprint 16 (2026-01-28 - 2026-02-11) label Jan 29, 2026
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:359-enhance-publishing-message-acknowledgement
ghcr.io/gdcc/configbaker:359-enhance-publishing-message-acknowledgement

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ChengShi-1 ChengShi-1 self-assigned this Feb 3, 2026
@ChengShi-1 ChengShi-1 moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Feb 3, 2026
@ChengShi-1
Copy link
Contributor

It looks good

Apply settings/:PublishDatasetDisclaimerText,
image
After DELETE /settings/:PublishDatasetDisclaimerText
image

@ChengShi-1 ChengShi-1 merged commit 180aa55 into develop Feb 3, 2026
21 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Feb 3, 2026
@ChengShi-1 ChengShi-1 removed their assignment Feb 3, 2026
@pdurbin pdurbin added this to the 6.10 milestone Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Publishing & Versions FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) FY26 Sprint 16 FY26 Sprint 16 (2026-01-28 - 2026-02-11) Original size: 3 Project: HDV SPA Rollout Size: 10 A percentage of a sprint. 7 hours.

Projects

Status: Merged 🚀

8 participants