-
Notifications
You must be signed in to change notification settings - Fork 532
Add acknowledgment before publishing #12051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChengShi-1
merged 30 commits into
develop
from
359-enhance-publishing-message-acknowledgement
Feb 3, 2026
Merged
Add acknowledgment before publishing #12051
ChengShi-1
merged 30 commits into
develop
from
359-enhance-publishing-message-acknowledgement
Feb 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pdurbin
reviewed
Jan 14, 2026
src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sekmiller
approved these changes
Jan 21, 2026
Contributor
sekmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of hate it when an integration test wipes out data or settings, but I know I'm in the minority here.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature: Publishing & Versions
FY26 Sprint 12
FY26 Sprint 12 (2025-12-03 - 2025-12-17)
FY26 Sprint 13
FY26 Sprint 13 (2025-12-17 - 2025-12-31)
FY26 Sprint 14
FY26 Sprint 14 (2025-12-31 - 2026-01-14)
FY26 Sprint 15
FY26 Sprint 15 (2026-01-14 - 2026-01-28)
FY26 Sprint 16
FY26 Sprint 16 (2026-01-28 - 2026-02-11)
Original size: 3
Project: HDV SPA Rollout
Size: 10
A percentage of a sprint. 7 hours.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


What this PR does / why we need it: The repository has been inundated with potential sensitive data and article-only deposits that conflict with the policies and mission.
Depositors should receive an additional confirmation request on publishing, that they acknowledge.
Which issue(s) this PR closes: IQSS/dataverse.harvard.edu#359
Special notes for your reviewer: It was decided not to modify the APIs at this time.
Suggestions on how to test this: Use JSF UI to publish a draft dataset with and without the setting "PublishDatasetDisclaimerText" set. You should see the disclaimer, contained in the setting, when the setting is set and the "Continue" button should be disabled until the checkbox is checked.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included
Additional documentation: