Draft
Conversation
- Introduce Google Guice for dependency injection in a small way - if we like it we can broaden usage over time. - Admin verticle now registers v2 api. - V2 api with one endpoint - Tests (other tests are broken - TODO!)
Tidy up inconsistent comment formats. Allow the admin verticle to start without a v2 API. Add auth to the new site ID router. Switch to passing the parent router in to the v2 router - that way the admin Verticle doesn't need to know the path the v2 router wants to use.
Make the GetClientSideKeypairsBySite handler depend on an interface instead of the full clientside keypairs class.
…ew-restful-pattern # Conflicts: # README.md # src/main/java/com/uid2/admin/Main.java # src/main/java/com/uid2/admin/secret/IKeypairManager.java # src/main/java/com/uid2/admin/vertx/api/IRouteProvider.java # src/main/java/com/uid2/admin/vertx/api/V2Router.java # src/main/java/com/uid2/admin/vertx/api/V2RouterModule.java # src/main/java/com/uid2/admin/vertx/api/cstg/ClientSideKeypairResponse.java # src/main/java/com/uid2/admin/vertx/api/cstg/GetClientSideKeypairsBySite.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting this on-hold until we have a bigger discussion about DI.