Use lazy OnceLock Handlebars initialization for synthetic ID generation#75
Open
lassidevs wants to merge 2 commits intoIABTechLab:mainfrom
Open
Use lazy OnceLock Handlebars initialization for synthetic ID generation#75lassidevs wants to merge 2 commits intoIABTechLab:mainfrom
lassidevs wants to merge 2 commits intoIABTechLab:mainfrom
Conversation
Use a thread-safe OnceLock to lazily initialize and cache the global Handlebars renderer
Author
|
I love this IAB initiative so I wanted to contribute a small first-time PR. Please let me know if there's something needed to have this merged. I'm aware the multi-threaded support is not necessary for the current WASI 0.1-preview target, but it's in works and expected for 0.3.0, so I decided to add it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done
Handlebarsinstance in a thread-safe OnceLock. Prevents redundant template
registration and improves performance for high-throughput workloads, which is expected for synthetic id generation
Notes