Open
Conversation
Member
|
There seems to be an error on my end while trying to run the code. Did you happen to install minireset.css as a dependency? As for the hamburger menu, you can look into MUI Components: https://mui.com/material-ui/react-app-bar/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

To make centering the nav-items easier I had to "npm install minireset.css" there was an issue where we used position: absolute for the nav-items to keep the white space from appearing above the navbar. This is not scalable. The problem was with our reset/normalizing of the css (look it up for detail). By having a reset file, the white space problem was solved and it allowed me to readjust the nav-items easier and with using position: absolute, which is useful as it is scalable.
Using the minireset, the site now looks a bit better, it doesn't look as close up if you look closely. The hacked header is a bit more far away which will need adjusting, but everything else is the same (and I think it looks. abit better)