This repository was archived by the owner on Dec 7, 2023. It is now read-only.
Testing get for filter and user id#502
Open
asehgal4 wants to merge 6 commits intoHackIllinois:stagingfrom
Open
Testing get for filter and user id#502asehgal4 wants to merge 6 commits intoHackIllinois:stagingfrom
asehgal4 wants to merge 6 commits intoHackIllinois:stagingfrom
Conversation
Contributor
|
Wait until #498 gets merged before reviewing this. |
Nydauron
force-pushed
the
get_for_filter_and_user_id
branch
from
abb1e0c to
3a73f1e
Compare
Nydauron
suggested changes
Jan 12, 2023
Contributor
Nydauron
left a comment
Nydauron
left a comment
There was a problem hiding this comment.
Some tests to add:
GET /user/filter/- Add multi-filter test for
- Try to filter as a normal user and an unauthenticated user
GET /user/{id}/- Try to get by id as a normal user and an unauthenticated user
- Add not found test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.