This repository was archived by the owner on Dec 7, 2023. It is now read-only.
Batch acceptance and finalization of decisions#415
Open
Conversation
PatrickKan
reviewed
Oct 21, 2021
DevSatpathy
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to batch accept and batch finalize users.
Acceptance is done by updating the decision with the POST /decision/ endpoint, so this was batched by creating POST /decision/batch/.
Finalization is done with the POST /decision/finalize/ endpoint, so this was batched by creating POST /decision/finalize/batch/.
Both of these batched endpoints exist in the controller level, not the service level, so writing tests was not possible (we should look into end-to-end testing). For now the functionality was tested with Postman.
Closes #406