This repository was archived by the owner on Dec 7, 2023. It is now read-only.
Adressed #228 (Storing resume filename in registration object) and #283 (More descriptive configloader error messages)#321
Open
jacobmen wants to merge 5 commits intoHackIllinois:stagingfrom
Open
Conversation
This reverts commit 53782a0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited dev_config.json to include resumeName as field. Edited configloader.go generic error returns in the methods Load, Get, and ParseInto to be more descriptive.
REGISTRATION_STAT_FIELDS & REGISTRATION_DEFINITION in dev_config.json have field for resumeName
Exported generic errors in configloader.go removed
Returned errors in Load, Get, and ParseInto methods in configloader.go more descriptive in all returns