Open
Conversation
casassg
reviewed
Oct 3, 2018
Member
casassg
left a comment
casassg
left a comment
There was a problem hiding this comment.
Small review of current status
_layouts/base.html
Outdated
| <meta name="author" content="HackCU"/> | ||
| <meta name="theme-color" content="#315B7F"> | ||
| <meta name="copyright" content="HackCU"/> | ||
| <meta name="application-name" content="Local Hack Day 2018"/> |
Member
There was a problem hiding this comment.
Remember to change all the above tags
_layouts/base.html
Outdated
|
|
||
| <!-- CSS --> | ||
| <link rel="stylesheet" href="css/fall.css"> | ||
| <link rel="stylesheet" href="css/style.css"> |
Member
There was a problem hiding this comment.
Add ?_={{ site.time | date: '%s' }} for cache busting
Reference: http://www.adopsinsider.com/ad-ops-basics/what-is-a-cache-buster-and-how-does-it-work/
_layouts/base.html
Outdated
|
|
||
| <!-- JS --> | ||
| <script src='https://cdnjs.cloudflare.com/ajax/libs/gsap/1.20.3/TweenMax.min.js'></script> | ||
| <script src="js/fall.js"></script> |
README.md
Outdated
|
|
||
| 1. Remove background | ||
| 1. Resize the image to `600 x 400 px` centering | ||
| 3. Archive the original `.png` file in the corresponding `originals/` folder |
Member
There was a problem hiding this comment.
No logos on this page most probably, you can delete this lines.
| @@ -0,0 +1 @@ | |||
| # Contributing Guidelines No newline at end of file | |||
Author
There was a problem hiding this comment.
gonna keep so we know that we need contributing guidelines still or to update them
| <!-- Libs and Plugins CSS --> | ||
| <!-- <link rel="stylesheet" href="inc/bootstrap/css/bootstrap.min.css"> | ||
| <link rel="stylesheet" href="inc/font-awesome/css/font-awesome.min.css"> --> | ||
| <!-- Font Icons --> |
Member
There was a problem hiding this comment.
Would be cool to use Biko (official HackCU font). See files: https://github.com/HackCU/HackCU/tree/master/assets/fonts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The beginning design for the slack signup page.
Related Issues
n/a
Some questions
There aren't any but si.
Additional Notes
Do you want to add anything else? We ❤️ to hear your opinions!
Waiting on background image design and img for field from slack.hack.org.
Share how this made you feel