Update jTimeout.js - close tab across multiple windows when not using jAlert#32
Open
jhamsle wants to merge 1 commit intoHTMLGuyLLC:masterfrom
Open
Update jTimeout.js - close tab across multiple windows when not using jAlert#32jhamsle wants to merge 1 commit intoHTMLGuyLLC:masterfrom
jhamsle wants to merge 1 commit intoHTMLGuyLLC:masterfrom
Conversation
I made the "hideCountdownAlert" function overriddable. This way if someone wants to control their dialog/UI they'll be able to have it close properly across multiple windows. Note: "timeout.timeoutWarning = false;" should still be in the overridden method, or the pop-up won't display again and will continually fire "close" events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the "hideCountdownAlert" function overriddable. This way if someone wants to control their dialog/UI they'll be able to have it close properly across multiple windows. Note: "timeout.timeoutWarning = false;" should still be in the overridden method, or the pop-up won't display again and will continually fire "close" events.