Remove gRPC-related classes and proto-generated files no longer in us…#2
Open
OmmrGAZAR315 wants to merge 12 commits intomainfrom
Open
Remove gRPC-related classes and proto-generated files no longer in us…#2OmmrGAZAR315 wants to merge 12 commits intomainfrom
OmmrGAZAR315 wants to merge 12 commits intomainfrom
Conversation
…e to streamline the codebase.
…, controllers, and request/response handling. Integrate `GrpcServiceProvider` and update configuration and bootstrap files.
…eamline request handling, and introduce `CartController`. Update Docker environment variables and image version for compatibility. Remove unused gRPC config.
…ust method visibility, and refine service definitions.
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete proto-generated gRPC files and classes, streamlines service routing, and introduces a dynamic gateway for handling flexible gRPC requests.
- Deleted unused HealthService and GPBMetadata proto artifacts.
- Added
GrpcRouteRegistryandGrpcServiceRouterfor dynamic service/method routing. - Introduced
UserGrpcServiceand updated Cart/HTTP proxy services to use a gateway pattern.
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| app/Grpc/Services/UserGrpcService.php | Added gateway service to forward flexible gRPC calls |
| app/Grpc/Services/GrpcService.php | New HTTP-to-gRPC proxy (proxyRequest/dispatchGrpcRequest) |
| app/Grpc/GrpcRouteRegistry.php | New static registry for service-method mappings |
| app/Grpc/GrpcRoute.php | Fluent interface for registering gRPC routes |
| app/Console/Commands/GrpcServeCommand.php | Updated server command to handle UserGrpcService |
| app/Grpc/GPBMetadata/User/UserService.php | Removed generated proto metadata for UserService |
| $responseData = new Any(); | ||
| $resource = new UserResource($user); | ||
| $responseData->setValue(json_encode([ | ||
| 'data' => $resource |
There was a problem hiding this comment.
[nitpick] Passing a UserResource object directly into json_encode may not yield the expected structure; consider converting it to an array (e.g., $resource->toArray()) before encoding.
Suggested change
| 'data' => $resource | |
| 'data' => $resource->toArray() |
|
|
||
| namespace App\Grpc\Services; | ||
|
|
||
| use App\Grpc\Controllers\BaseGrpcService; |
There was a problem hiding this comment.
The BaseGrpcService import is not referenced in this file; remove the unused import to clean up the code.
Suggested change
| use App\Grpc\Controllers\BaseGrpcService; |
Comment on lines
+53
to
+54
| if ($bearerToken = request()->bearerToken()) | ||
| $metadata['authorization'] = ['Bearer ' . $bearerToken]; |
There was a problem hiding this comment.
[nitpick] Use braces for the if statement to avoid ambiguity and make future expansions safer (e.g., if (...) { ... }).
Suggested change
| if ($bearerToken = request()->bearerToken()) | |
| $metadata['authorization'] = ['Bearer ' . $bearerToken]; | |
| if ($bearerToken = request()->bearerToken()) { | |
| $metadata['authorization'] = ['Bearer ' . $bearerToken]; | |
| } |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…methods, simplify request handling, and adjust service definitions for improved consistency and maintainability.
…pdate ProductHandler for dependency injection
…cAuthMiddleware`, and migrate `logout` method from UserServer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e to streamline the codebase.