Open
Conversation
| @@ -0,0 +1,25 @@ | |||
| # GovStack Consent BB - mock | |||
Contributor
There was a problem hiding this comment.
Can we get some level of “genericisation” here? Make it clear that this is a template mock api rather than one for consent?
rachellawson
suggested changes
Oct 13, 2022
Contributor
rachellawson
left a comment
rachellawson
left a comment
There was a problem hiding this comment.
I like it, though for use in the template, we probably need to make it clear it is a generic template rather than something specific for consent. Simply to avoid having to explain that every time.
|
I'm doing some changes in bb-consent, I've added a layer that reproduces static JSON responses from files. I'll probably add more. It makes sense to me that this PR is merged with @rachellawson's adjustments, but I think we should definitely also find a good process for "backporting" changes from building blocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the Consent BB's "mock" application to our template folder. The idea is that each BB should be able to stand up a mock server which replies to HTTP requests according to their own OpenAPI specification. This needs generification and testing, either before or after merging depending on whether we prioritize "getting it out there" or "getting it right"