This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Add sql file for creating tables#239
Open
liyanhui1228 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Open
Add sql file for creating tables#239liyanhui1228 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
liyanhui1228 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
sql_schema/create_table.sql
Outdated
| @@ -0,0 +1,6 @@ | |||
| CREATE TABLE self_compatibility_status (install_name VARCHAR(200), status VARCHAR(20), py_version VARCHAR(5), timestamp TIMESTAMP, details VARCHAR(5000), PRIMARY KEY (install_name, py_version)); | |||
Contributor
There was a problem hiding this comment.
Is there a text type that you can use instead of VARCHAR(5000)? I think that you only need VARCHAR to support queries). Why is py_version 5 characters?
| @@ -0,0 +1,5 @@ | |||
| CREATE TABLE self_compatibility_status (install_name VARCHAR(200), status VARCHAR(20), py_version VARCHAR(1), timestamp TIMESTAMP, details TEXT, PRIMARY KEY (install_name, py_version)); | |||
Contributor
There was a problem hiding this comment.
It seems like, in the production table, the timestamp is auto-updating?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.