This repository was archived by the owner on Oct 21, 2022. It is now read-only.
semver checker: do not return error msg on new args with default values#202
Open
ylil93 wants to merge 8 commits intoGoogleCloudPlatform:masterfrom
Open
semver checker: do not return error msg on new args with default values#202ylil93 wants to merge 8 commits intoGoogleCloudPlatform:masterfrom
ylil93 wants to merge 8 commits intoGoogleCloudPlatform:masterfrom
Conversation
ylil93
force-pushed
the
semver_checker
branch
2 times, most recently
from
b6f56e6 to
18572d0
Compare
- neither regular nor optional args cannot be removed - args can be added as optional args - arg order must be preserved - default values must be preserved - required args can be made optional - logic currently assumes *args and **kwargs are the last two args - added more test cases
ylil93
force-pushed
the
semver_checker
branch
from
1d0e4ca to
51d5bf2
Compare
| 'single_args': [arg1, arg2, ...], | ||
| 'defaults': {arg1: value1, ...}, | ||
| 'vararg': argv, | ||
| 'kwarg': kwargs, |
Contributor
There was a problem hiding this comment.
Don't you need to know the position of these things?
Contributor
Author
There was a problem hiding this comment.
I get the args using ast tooling which returns the args in order.
brianquinlan
approved these changes
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.