don't convert (unindexed) ascii str to bytes in GenericProperty#100
Open
pnico wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Open
don't convert (unindexed) ascii str to bytes in GenericProperty#100pnico wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
pnico wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
pnico
changed the title
ludoch
requested review from
asriniva and
shreejad
and removed request for
asriniva
pnico
force-pushed
the
fix/generic-property-ascii-str
branch
from
4e733ec to
546bb38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99 (but only for non-indexed properties), while keeping the same behavior as before if the value was passed as a
bytesobject or if the property is indexed