add <Footer /> component#47
add <Footer /> component#47kryptokinght wants to merge 10 commits intoGirlScriptSummerOfCode:masterfrom
Conversation
|
Since this Pull Request originated from a forked repository, Now cannot deploy it as there are potential security risks. If you are a collaborator on this repository, consider making this Pull Request from a branch on the same repository instead of a fork. |
0x48piraj
left a comment
0x48piraj
left a comment
There was a problem hiding this comment.
Fix the code, squash the commits down to 1 or 2.
bogas04
left a comment
bogas04
left a comment
There was a problem hiding this comment.
Sorry for late review, could you please make these changes? Thank you so much!
| <link | ||
| rel="stylesheet" | ||
| href="http://maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.min.css" | ||
| /> |
There was a problem hiding this comment.
Could you please remove fonts and external CSS? Thank you so much!
| Advancement by Youth), was established in May 2010 by a group of | ||
| young engineers from IITs and NITs. | ||
| </p> | ||
|
|
There was a problem hiding this comment.
Would it be possible to break the Footer component into smaller components? Anything beyond 150 lines of code seems excessive enough to read.
There was a problem hiding this comment.
ok, working on it!
3 participants
This is a basic version. Further changes will be made on your suggestions .
UPDATE: