Add <CheckoutButton /> Component#27
Open
MadhavBahl wants to merge 1 commit intoGirlScriptSummerOfCode:masterfrom
Open
Add <CheckoutButton /> Component#27MadhavBahl wants to merge 1 commit intoGirlScriptSummerOfCode:masterfrom
MadhavBahl wants to merge 1 commit intoGirlScriptSummerOfCode:masterfrom
Conversation
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
bogas04
requested changes
Jun 27, 2018
| import React from 'react'; | ||
|
|
||
| const CheckoutButton = () => ( | ||
| <React.Fragment> |
Collaborator
There was a problem hiding this comment.
Could you take ({ children, ...otherProps }) and instead of hard coded text put children and spread otherProps at root component (a)? This way we can bind event listeners, classNames etc.
Contributor
Author
There was a problem hiding this comment.
Alright, will do this tonight :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added component which resolves issue #14
The issue can be closed now