fix(vyos): use native load command for Ansible deployments#60
Merged
fix(vyos): use native load command for Ansible deployments#60
Conversation
The vyos.vyos.vyos_config Ansible module claims to support bracket format configuration files but has two critical bugs: 1. Doesn't parse /* */ comments (treats them as commands) 2. Incorrectly converts bracket format to set commands This change switches to using VyOS's native `load` command which properly handles bracket format with comments - the same approach used for manual USB provisioning. Changes: - Rewrite deploy.yml to SCP config to router and use `load` command - Add .gitignore for rendered configs and backup artifacts - Add eth2 interface definition to gateway.conf 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1a2a354 to
8121d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy.ymlto use VyOS nativeloadcommand instead of brokenvyos_configmodule.gitignorefor rendered configs and backup artifactsgateway.confProblem
The
vyos.vyos.vyos_configAnsible module claims to support bracket format configuration files but has critical bugs:Doesn't parse
/* */comments - Treats them as commands, resulting in errors like:Incorrectly converts bracket format to set commands - For example,
firewall { interface eth0 {...}}becomes invalidset firewall interface eth0...Solution
Use VyOS's native
loadcommand which properly handles bracket format with comments - the same approach used for manual USB provisioning:/tmp/gateway.conf)configure→load→commit→save→exitThis mirrors the working manual process:
Test plan
🤖 Generated with Claude Code