[CHA-0] Fix QueryReminders to use filter parameter and improve test assertions#214
Merged
nijeesh-stream merged 2 commits intomasterfrom Nov 20, 2025
Merged
[CHA-0] Fix QueryReminders to use filter parameter and improve test assertions#214nijeesh-stream merged 2 commits intomasterfrom
nijeesh-stream merged 2 commits intomasterfrom
Conversation
hifaizsk
approved these changes
Nov 19, 2025
| """ | ||
| params = options.copy() | ||
| params["filter_conditions"] = filter_conditions or {} | ||
| params["filter"] = filter_conditions or {} |
There was a problem hiding this comment.
Just a note: if you've renamed the param to filter here, should the func arg (filter_conditions) change also as the other args match the params (user_id & user_id etc)?
Appreciate this might be a breaking change which is why you haven't. Thought worth mentioning for consistency.
Contributor
Author
There was a problem hiding this comment.
same, i didn't want to change it as its a breaking change
10printhello
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLA
Description of the pull request
Changes
query_remindersAPI call to usefilterparameter instead offilter_conditions(both sync and async clients)message_idfilter andchannel_cidfilter verificationWhy
filter, notfilter_conditionsTesting