Java 14 sort, SMB3 shuffle, & bugfixes galore#101
Open
warmCabin wants to merge 27 commits intoGaming32:mainfrom
Open
Java 14 sort, SMB3 shuffle, & bugfixes galore#101warmCabin wants to merge 27 commits intoGaming32:mainfrom
warmCabin wants to merge 27 commits intoGaming32:mainfrom
Conversation
I grabbed DualPivotQuickSort by ctrl+clicking into Arrays.sort. Turns out I had my IDE settings pointing to Java 14 for this project, even though maven was set to use Java 11. Why is IntelliJ like this?
I'm going to make markArray throw these early.
UNINITIALIZED_VALUE means the textbox was empty. This method never actually checked which button was clicked.
This reverts commit 67e15ff.
Didn't realize I was working around generated code here at first!
If the starting offset is too high, 1/arrayLength will be less than the minimum float delta at that point. When that happens, we get 9001 copies of the same brown noise output. By using Math.nextUp, we'll get spikier slopes in this case instead of an empty box.
The idea here is to normalize the minimum to 0. Now it works whether that minimum is positive or negative.
I searched the project for href and found this interesting design decision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sup? Been having some fun with this project lately. I'd be happy to split these out into multiple branches if you want to cherry pick.
New features:
Bug Fixes:
*(float*)(*((int*)&randomStart) + 1). The real fix is to use doubles.