Adding wrappers for device math functions and polar decomposition#349
Open
Adding wrappers for device math functions and polar decomposition#349
Conversation
…alculates the polar decomposition of a 3x3 square matrix
…o feature/crook5/math
cmcrook5
changed the title
cmcrook5
force-pushed
the
feature/crook5/math
branch
from
c52307f to
c3fcf1f
Compare
corbett5
reviewed
Jun 18, 2025
Collaborator
corbett5
left a comment
corbett5
left a comment
There was a problem hiding this comment.
Marginal comments aside it looks good to me. I'd just add some tests for the math functions you added too.
The tensorOps stuff is pretty convoluted, but it looks you figured it out. Hope it wasn't too much trouble.
| /** | ||
| * @brief Move assignment operator.. | ||
| * @param src the SparsityPatternView to be moved from. | ||
| * @param src the ArrayOfArraysView to be moved from. |
| if( size > 0 ) | ||
| { | ||
| LVARRAY_ERROR_IF_NE_MSG( space, MemorySpace::host, "Calling reallocate with a non-zero current size is not yet supporeted for the GPU." ); | ||
| LVARRAY_ERROR_IF_NE_MSG( space, MemorySpace::host, "Calling reallocate with a non-zero current size is not yet supported for the GPU." ); |
|
|
||
| #if defined( LVARRAY_USE_DEVICE ) | ||
|
|
||
| /// @copydoc ceil( T ) |
Collaborator
There was a problem hiding this comment.
Unless you added tests for __half I'd just get rid of them.
| } | ||
| }; | ||
|
|
||
| /** |
Collaborator
There was a problem hiding this comment.
I'm a little unsure if this should go here or in GEOS itself.
…o feature/crook5/math
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added LvArray wrappers for ceil, floor, and power math functions that were previously missing from the develop branch. Also include polarDecomposition from Stefan's previous work.