feat: Deduce access level in PyArrayWrapper from constness of given array reference#336
Open
av-novikov wants to merge 4 commits intodevelopfrom
Open
feat: Deduce access level in PyArrayWrapper from constness of given array reference#336av-novikov wants to merge 4 commits intodevelopfrom
av-novikov wants to merge 4 commits intodevelopfrom
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports the construction of PyArrayWrapper with a MODIFIABLE access level. Before the access level was READ_ONLY by default. Now the access level is chosen based on the constness of the reference of the underlying Array.
It is convenient and allows to avoid the change of access level from Python in GEOS: PR 3391. This is important to not add extra code to Python, because we are going to use the Python interface common between GEOS and open-darts.
We are going to use it in embedding of Python function in C++. In the example, the function has READ_ONLY first argument and MODIFIABLE second one, which we write to in Python. The example: typedef and use