Conversation
|
If merged, this would definitely break the way CircleCI is setup to test currently so once you get write access to the repo - we should talk through it and get you setup on CircleCI. As for 2.7 compliance - that's the beauty of the automated tests that run across multiple python versions! If it doesn't pass, you'll get a warning and it won't be allowed to merge. |
|
Thanks for the feedback, back to drafts until sorted |
|
@kylenstone one more thing that needs to be updated is the Circle CI config so that it can find the newly re-named integration test file. |
|
@kylenstone, now that I've got the integration test in a good place w/ xxhash verification working correctly and passing most of the time - I'd love to come back to this PR and get your improvements merged in! |
My first PR at Frame.io so I'm saving this as a Draft for now. Few things to point out:
integration.py(I also moved this file) because pytest will run the tests automatically. @jhodges10 it's possible this was actually needed for CircleCI so I wanted your eyes on it.frameioclientfixture assetup_clientwhich seems like a better fixture name for actual use in following tests. I modified the other tests to use it.single_file_upload, I didn't want to re-use the upload path from the existing test because it was doing so much work already.In a later PR, we should figure out a better setup and teardown lifecycle