Allowing solenoidal projections using a full schur complement solve#365
Draft
cianwilson wants to merge 15 commits intomainfrom
Draft
Allowing solenoidal projections using a full schur complement solve#365cianwilson wants to merge 15 commits intomainfrom
cianwilson wants to merge 15 commits intomainfrom
Conversation
Fails because the preconditioner matrix is assumed to exist, when it doesn't. Also depends on an options path in Full_Projection that isn't compatible with being called from solenoidal projection instead of momentum equation.
…e right. Also some fixes to two tests that failed the updated logic because they were themselves inconsistent.
…xistence) preconditioner_matrix. Also allow correct velocity to take in a option path as it also has assumed locations for velocity solver options. Add a test that appears to pass that uses Schur complement solenoidal projection. Need to look at this more.
…e necessary but unrelated to other changes in this branch.
…ions. diag and lump appear to be best with tolerances increased for no and mass due to poor convergence
…c numbering so that we get a second order halo when it's required.
…it appropriately.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a draft at the moment to keep track/refresh my memory of the changes.