Conversation
WalkthroughRefines a CSS selector in Enhanced Tabs: the border-right removal rule now excludes tabs that are followed by a hidden Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/main/resources/META-INF/frontend/fcEnhancedTabs/fc-enhanced-tabs.css`:
- Line 91: The selector uses chained :not() pseudo-classes which Stylelint
flags; update the rule in fc-enhanced-tabs.css where the selector
"&:not(:last-child):not(:has(+
vaadin-menu-bar-button[slot="overflow"][hidden]))" appears to use the CSS
Selectors Level 4 combined :not() form instead (e.g., merge the two not(...)
arguments into a single :not(..., ...)) so it becomes a single :not() with both
conditions to satisfy the selector-not-notation rule.
src/main/resources/META-INF/frontend/fcEnhancedTabs/fc-enhanced-tabs.css
Outdated
Show resolved
Hide resolved
84bebf0 to
b0089f0
Compare
|
paodb
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Do not remove the right border from the
vaadin-menu-bar-buttonimmediately preceding a hidden overflow button.Summary by CodeRabbit