Skip to content

fix: fix right border style in aura theme#27

Merged
paodb merged 1 commit intomasterfrom
aura-fix
Feb 12, 2026
Merged

fix: fix right border style in aura theme#27
paodb merged 1 commit intomasterfrom
aura-fix

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Feb 11, 2026

Do not remove the right border from the vaadin-menu-bar-button immediately preceding a hidden overflow button.

image

Summary by CodeRabbit

  • Bug Fixes
    • Fixed tab border rendering so right borders remain visible when an adjacent overflow control is present but hidden, preventing inconsistent border removal and ensuring consistent tab appearance across edge cases.

@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

Walkthrough

Refines a CSS selector in Enhanced Tabs: the border-right removal rule now excludes tabs that are followed by a hidden vaadin-menu-bar-button[slot="overflow"], preventing border removal when such an overflow button is present.

Changes

Cohort / File(s) Summary
Enhanced Tabs CSS Selector
src/main/resources/META-INF/frontend/fcEnhancedTabs/fc-enhanced-tabs.css
Adjusted selector from :not(:last-child) to :not(:last-child, :has(+ vaadin-menu-bar-button[slot="overflow"][hidden])) so border-right isn't removed when a hidden overflow button immediately follows a tab.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • chore: add aura styles #26: Similar edits to fc-enhanced-tabs.css addressing border behavior when a hidden overflow button follows a tab.

Suggested reviewers

  • mlopezFC
  • paodb
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'fix: fix right border style in aura theme' is directly related to the main change, which modifies CSS border styling in the enhanced tabs component for the aura theme.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aura-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/main/resources/META-INF/frontend/fcEnhancedTabs/fc-enhanced-tabs.css`:
- Line 91: The selector uses chained :not() pseudo-classes which Stylelint
flags; update the rule in fc-enhanced-tabs.css where the selector
"&:not(:last-child):not(:has(+
vaadin-menu-bar-button[slot="overflow"][hidden]))" appears to use the CSS
Selectors Level 4 combined :not() form instead (e.g., merge the two not(...)
arguments into a single :not(..., ...)) so it becomes a single :not() with both
conditions to satisfy the selector-not-notation rule.

@sonarqubecloud
Copy link

@javier-godoy javier-godoy requested a review from paodb February 11, 2026 15:08
@javier-godoy javier-godoy changed the title fix: fix border style in aura theme fix: fix right border style in aura theme Feb 11, 2026
@paodb paodb merged commit 2536f5c into master Feb 12, 2026
7 checks passed
@paodb paodb deleted the aura-fix branch February 12, 2026 17:03
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants