Clean anchor modules PR (no BEM files)#22
Open
fmormer wants to merge 4 commits intoFloatingArrayDesign:mainfrom
Open
Clean anchor modules PR (no BEM files)#22fmormer wants to merge 4 commits intoFloatingArrayDesign:mainfrom
fmormer wants to merge 4 commits intoFloatingArrayDesign:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[UPDATE] This PR includes only anchor-related files originally introduced in commit 7de4650.
All BEM/WAMIT/Hydrostar output files have been excluded.
It includes updates to:
examples/05_Anchors/famodel/anchors/tests/test_anchors.py and testOntology.yamlPlease use "Squash and merge" to consolidate changes into a single commit.
Let me know if any adjustments are needed
{ORIGINAL DESCRIPTION] This pull request includes a number of upgrades and new features developed under FAModel_anchors, focused on the anchor module and its integration with the overall FAModel workflow. Key additions include:
examples/05_AnchorsAnchorclass modifications - ongoing processgetSizeAnchormethods within theAnchorclassThese updates are intended to improve the flexibility and reliability of anchor design workflows. All changes have been tested locally using the available test suite but there might be some incompatibilities under the radar that might raise with users feedback.