Add an async variant to Catching.catch#34
Merged
Jeehut merged 2 commits intoFlineDev:mainfrom May 3, 2025
Merged
Conversation
…ther than wrapping in a caught enum.
Contributor
Author
|
I've also changed the logic a bit such that if the error caught by the catch is already of the target type, it just throws it directly rather than wrapping it in another error inside the caught case. |
Jeehut
changed the title
Member
|
@jubishop Thank you very much, those are 2 good catches I missed initially. Code looks good, too. Great job! 🎉 Merging as is. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32