Skip to content

refactor(web): improve layout and styling of storage provider components #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
virajbhartiya wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(web): improve layout and styling of storage provider components #120

virajbhartiya wants to merge 3 commits into from

Conversation

@virajbhartiya
Copy link
Contributor

@virajbhartiya virajbhartiya commented Jan 13, 2026 •
edited
Loading

  • Adjusted padding and margin in various components for better responsiveness.
  • Updated grid layouts in ProviderDetailModal and MetricRow for improved display on different screen sizes.
  • Enhanced button text visibility in ProviderFilters with responsive text sizes.
  • Modified Card component styles for consistent padding across different screen sizes.

Closes #107

@virajbhartiya
refactor(web): improve layout and styling of storage provider components
72d75ae 
- Adjusted padding and margin in various components for better responsiveness.
- Updated grid layouts in ProviderDetailModal and MetricRow for improved display on different screen sizes.
- Enhanced button text visibility in ProviderFilters with responsive text sizes.
- Modified Card component styles for consistent padding across different screen sizes.
@vercel
Copy link

vercel bot commented Jan 13, 2026

@virajbhartiya is attempting to deploy a commit to the FilOz Team on Vercel.

A member of the Team first needs to authorize it.

@FilOzzy FilOzzy added this to FOC Jan 13, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Jan 13, 2026
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FOC Jan 13, 2026
@rjan90 rjan90 requested a review from SgtPooki January 13, 2026 05:57
@BigLep BigLep requested a review from silent-cipher January 15, 2026 07:23
@BigLep BigLep added this to the M4: Filecoin Service Liftoff milestone Jan 15, 2026
silent-cipher
silent-cipher requested changes Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@silent-cipher silent-cipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're still some mobile issues that need to be addresses. I've attached screenshots below for reference.

Image Image Image

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to ⌨️ In Progress in FOC Jan 16, 2026
@BigLep BigLep mentioned this pull request Jan 16, 2026
Merged
@virajbhartiya
refactor(web): enhance layout and structure of storage provider metrics
6430d59 
- Updated grid layout in MetricRow and ProviderCardDetailedStats for improved responsiveness.
- Simplified the structure of the success rates section in ProviderCardDetailedStats.
- Adjusted styling in ProviderDetailModal for better alignment and spacing.
@SgtPooki
Copy link
Collaborator

SgtPooki commented Jan 19, 2026

@virajbhartiya thanks for the PR! Please let us know when you think this PR is ready for another review

@SgtPooki SgtPooki marked this pull request as draft January 22, 2026 13:12
@virajbhartiya virajbhartiya marked this pull request as ready for review January 22, 2026 17:40
@rjan90 rjan90 moved this from ⌨️ In Progress to 🔎 Awaiting review in FOC Jan 23, 2026
@rjan90
Copy link
Contributor

rjan90 commented Jan 27, 2026

@virajbhartiya is this ready for review now? Have you addressed the UI-issue that Pushpendra mentioned here: #120 (review)

@SgtPooki
Copy link
Collaborator

SgtPooki commented Jan 27, 2026

it looks like CI is still failing. you might need to run pnpm lint && pnpm check && pnpm format from the root

@rjan90 rjan90 moved this from 🔎 Awaiting review to ⌨️ In Progress in FOC Jan 28, 2026
@virajbhartiya
Copy link
Contributor Author

virajbhartiya commented Jan 30, 2026

fixed it @SgtPooki

@BigLep BigLep moved this from ⌨️ In Progress to 🔎 Awaiting review in FOC Jan 30, 2026
@rjan90 rjan90 moved this from 🔎 Awaiting review to ⌨️ In Progress in FOC Feb 1, 2026
@SgtPooki
Copy link
Collaborator

SgtPooki commented Feb 2, 2026

running this locally so I can get some metrics generated so i can see the different cards..

@SgtPooki
Copy link
Collaborator

SgtPooki commented Feb 2, 2026

this still seems like it's not fixed.

image image

SgtPooki
SgtPooki requested changes Feb 2, 2026
View reviewed changes
Copy link
Collaborator

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not fixed.. the UI isn't displaying well on mobile at all. The main thing I was concerned about with #107 was the "view detailed metrics" and it appears to be worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtPooki SgtPooki SgtPooki requested changes

@silent-cipher silent-cipher Awaiting requested review from silent-cipher

Requested changes must be addressed to merge this pull request.

Assignees

@virajbhartiya virajbhartiya

Labels

None yet

Projects

FOC
Status: ⌨️ In Progress

Milestone

M4.1: mainnet ready

Development

Successfully merging this pull request may close these issues.

Mobile bug: detailed metrics breaks users tab

5 participants

@virajbhartiya @SgtPooki @rjan90 @silent-cipher @BigLep