Clean: Update glossiness API, to be able to have a default specular color if none provided#279
Open
FarhadG wants to merge 3 commits intoFamous:developfrom
Open
Clean: Update glossiness API, to be able to have a default specular color if none provided#279FarhadG wants to merge 3 commits intoFamous:developfrom
FarhadG wants to merge 3 commits intoFamous:developfrom
Conversation
Contributor
Author
|
Just FYI, this will break the old API, as the previous one required that you pass in a I will push up a demo for this, very soon. |
Contributor
Author
|
All updates have been made and here's a DEMO showcasing the updates. |
Member
|
@FarhadG Can you update the commits so that the second commit is marked as a breaking change? Thanks. |
Contributor
Author
|
Updated to |
added 2 commits
July 8, 2015 13:22
…r color if none provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A more intuitive glossiness API, along with a default specular color if none was provided (based off the light color).