Frontend source code not removed from docker build for new web GUI#811
Open
mcserep wants to merge 1 commit intoEricsson:masterfrom
Open
Frontend source code not removed from docker build for new web GUI#811mcserep wants to merge 1 commit intoEricsson:masterfrom
mcserep wants to merge 1 commit intoEricsson:masterfrom
Conversation
Collaborator
Author
|
Should only be merged after #612 is resolved, since this makes fixing production easier until then 😅 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CMake build configuration for the new web GUI where the frontend source code was not being properly removed during Release builds.
- Changed
file(REMOVE ...)tofile(REMOVE_RECURSE ...)to properly delete the entireappdirectory and its contents
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly remove application source code in case of Release build for new webGUI.