[0.17] Chainparams: Introduce consensus.genesis_style for compatibility#436
Closed
jtimon wants to merge 2 commits intoElementsProject:elements-0.17from
Closed
[0.17] Chainparams: Introduce consensus.genesis_style for compatibility#436jtimon wants to merge 2 commits intoElementsProject:elements-0.17from
jtimon wants to merge 2 commits intoElementsProject:elements-0.17from
Conversation
jtimon
force-pushed
the
e17-genesis-style
branch
from
d3b93ad to
5c90b43
Compare
jtimon
changed the title
jtimon
force-pushed
the
e17-genesis-style
branch
from
5c90b43 to
abca2d2
Compare
This was referenced Oct 17, 2018
jtimon
changed the title
jtimon
force-pushed
the
e17-genesis-style
branch
from
abca2d2 to
0fcd8af
Compare
jtimon
changed the title
jtimon
force-pushed
the
e17-genesis-style
branch
2 times, most recently
from
01fd213 to
e195010
Compare
jtimon
force-pushed
the
e17-genesis-style
branch
2 times, most recently
from
c7f7b90 to
e75f8a0
Compare
jtimon
force-pushed
the
e17-genesis-style
branch
from
e75f8a0 to
806b355
Compare
Contributor
|
Why not just provide the raw coinbase instead of a predefined "style", and default it to whatever commitments you want? |
Contributor
Author
|
Well, ideally the styles would unify with time (at least some of them, for example, liquidV1 has its own style not included here) and this seemed simpler. Feel free to create a competing PR. By the way, since liquid is now public, liquidv1's style could be implemented and tested here. Or perhaps I can do that on a separated PR on top of this one. |
Contributor
|
@luke-jr raw coinbase such as what exactly? Just trying to understand the suggestion |
Contributor
|
just noting we can add this test post-merge: f00e979#diff-912bf7afc60ccdf9de453ce3a8e0ffceR29 here |
Contributor
|
Closing for now, we're supporting this piecemeal. |
Contributor
Author
|
I don't follow. What piece of meal?
Why is it closed?
…On Tue, Dec 18, 2018, 22:10 Gregory Sanders ***@***.*** wrote:
Closed #436 <#436>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA9jSnfiLlFe74wBtGiTHkTid3wH2qxZks5u6VnigaJpZM4XjDge>
.
|
Contributor
|
I meant that Carl has taken half of this PR(note #467) and introduced two genesis styles already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces consensus.genesis_style for compatibility and sanity tests.
Style "default_style" is what is meant to be used and extended, since it opens the door to commit to any chainparams we would like to commit.
Style "regtest2_style" is for compatibility with bitcoin/bitcoin#8994
I'm trying to make sure that #433 can be compatible with kallewoof/bitcoin#5 using "signet_old" in #433, but I'm not getting the genesis block hash that I expect, this is driving me kind of crazy, see kallewoof/bitcoin#6 for additional context.
In the PR for block signing I plan to create another style for elements-0.14 compatibility.