About page, project sorting and project dropdown in navbar#16
About page, project sorting and project dropdown in navbar#164xdk wants to merge 11 commits intoEffectiveAF:masterfrom
Conversation
| if (rawPursuance !== undefined) { | ||
| return rawPursuance.name; | ||
| } else { | ||
| return "Jump to a pursuance"; |
There was a problem hiding this comment.
return "Jump to a " + PROJECT;, please
| pursuances[currentPursuanceId] : ""; | ||
| return ( | ||
| <div className="content about"> | ||
| <h1>About This Pursuance</h1> |
|
Done and done :) |
|
Added some CSS fixes for project selection dropdown on tablet (hidden between 768px and 960px) and in mobile menu |
|
@4xdk How about hiding the new project switcher dropdown between screen widths 768px and 1199px? |
|
Could just set a max width for the dropdown element too ... I'll have a look |
@4xdk That's true, though then someone could join a project with a long name and have the switcher disappear on the device they're using, which is kind of weird... though I guess always hiding it for that screen size just in case they join a project with a long time would kind of suck. Ah, maybe setting a max-width for the name of the project as visible at the top of the switcher (but allowing the name to take up multiple lines once the drop-down is expanded) and doing |
|
Yeah, was thinking about the second option. Good idea about multiple lines in the dropdown itself, shouldn't be a problem. |
|
@4xdk 👍 |
|
Should be good now @elimisteve |
|
Re. the conflict: just keep both changes one after another. |
2 participants
Based on: PursuanceProject/pursuance#219
Issues: PursuanceProject/pursuance#122 and PursuanceProject/pursuance#123