Improve progress bar updating in xml creation tasks on backend#322
Open
haniffm wants to merge 5 commits intoESSolutions:masterfrom
Open
Improve progress bar updating in xml creation tasks on backend#322haniffm wants to merge 5 commits intoESSolutions:masterfrom
haniffm wants to merge 5 commits intoESSolutions:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=========================================
- Coverage 54.7% 54.3% -0.41%
=========================================
Files 160 160
Lines 11534 11563 +29
Branches 1493 1507 +14
=========================================
- Hits 6310 6279 -31
- Misses 5031 5085 +54
- Partials 193 199 +6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
- Coverage 54.7% 54.56% -0.15%
==========================================
Files 160 160
Lines 11534 11559 +25
Branches 1493 1503 +10
==========================================
- Hits 6310 6307 -3
- Misses 5031 5058 +27
- Partials 193 194 +1
Continue to review full report at Codecov.
|
OskarPersson
requested changes
May 28, 2019
ESSArch_Core/ip/utils.py
Outdated
|
|
||
| generator = XMLGenerator() | ||
| generator.generate(files_to_create, folderToParse=ip.object_path, algorithm=algorithm) | ||
| for _ in generator.generate(files_to_create, folderToParse=ip.object_path, algorithm=algorithm): |
Contributor
There was a problem hiding this comment.
We can probably use yield from here instead of the loop. (Note that the loop body also can be deleted, it's just that Github doesn't allow multi line suggestions atm)
Suggested change
| for _ in generator.generate(files_to_create, folderToParse=ip.object_path, algorithm=algorithm): | |
| yield from generator.generate(files_to_create, folderToParse=ip.object_path, algorithm=algorithm) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.