Add new GregClient constructor to accept custom http client#116
Merged
aparajit-pratap merged 3 commits intomasterfrom May 27, 2025
Merged
Add new GregClient constructor to accept custom http client#116aparajit-pratap merged 3 commits intomasterfrom
aparajit-pratap merged 3 commits intomasterfrom
Conversation
8 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new GregClient constructor overload that accepts a custom HttpClient, enabling no-network mode in Dynamo and applying conditional TLS settings for older Windows versions.
- Imported
System.Net.Httpand added an overload to inject a customHttpClient. - Integrated optional
HttpClientintoRestClientinitialization with duplicated TLS setup logic. - Retained fallback to the existing
RestClientconstructor when noHttpClientis provided.
Comments suppressed due to low confidence (1)
src/GregClient/GregClient.cs:35
- The new constructor path with a custom
HttpClientisn't covered by existing tests; consider adding unit tests to verify initialization in no-network mode.
public GregClient(IAuthProvider provider, string packageManagerUrl, HttpClient httpClient)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
zeusongit
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This adds a new constructor to initialize
GregClientwith a custom HTTP client to be used for no-network mode in Dynamo. See Dynamo PR DynamoDS/Dynamo#16238.Declarations
Check these if you believe they are true
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of