WIP: Attempt to fix issue submitted via github#81
Draft
BenSandeen wants to merge 1 commit intomainfrom
Draft
Conversation
Author
|
ECI people, please let me know how to run the tests. I've never touched this code, so I have no idea if my changes will break things |
Contributor
|
I think |
Contributor
|
I'm not sure this needs fixing. I don't know exactly what they are trying to do, but I believe |
Author
|
Interesting.... Should I close this? And can someone respond to the person who filed the issue? |
Contributor
|
I'll respond on the issue to see if we can find out more about what they are trying to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Addresses: #80
Background
Our API doesn't store data properly as a JSON object; rather, it's a Ruby hash
Modification
Store objects as JSON
Result
API should store objects in a usable way
Additional Context
N/A
How to verify/test
I'm not sure yet, as I've never worked with this repo before. Please advise